Re: building pg_dump doesn't work - Mailing list pgsql-hackers

From Tom Lane
Subject Re: building pg_dump doesn't work
Date
Msg-id 3539.1236186877@sss.pgh.pa.us
Whole thread Raw
In response to Re: building pg_dump doesn't work  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: building pg_dump doesn't work  (Alvaro Herrera <alvherre@commandprompt.com>)
List pgsql-hackers
Alvaro Herrera <alvherre@commandprompt.com> writes:
>> Seems doable.

> Attached.

The TWO_MEMBER_SCANKEYWORD business seems a bit dangerous --- if the
header file is read without having #defined that correctly, bad things
will happen.  It might be better to leave that out, always define the
struct the same, and just have pg_dump define PG_KEYWORD to fill the
value field with zero.  Given alignment considerations, you're not
saving any space by omitting the field anyhow.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: SQL/MED compatible connection manager
Next
From: David Fetter
Date:
Subject: Re: SQL/MED compatible connection manager