Re: [PATCH] support tab-completion for single quote input with equal sign - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] support tab-completion for single quote input with equal sign
Date
Msg-id 3521570.1631135311@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] support tab-completion for single quote input with equal sign  (Jacob Champion <pchampion@vmware.com>)
Responses Re: [PATCH] support tab-completion for single quote input with equal sign
List pgsql-hackers
Jacob Champion <pchampion@vmware.com> writes:
> On Sat, 2021-09-04 at 11:32 -0400, Tom Lane wrote:
>> Independently of the concerns I raised, I'm wondering how come you
>> are getting different results.  Which readline or libedit version
>> are you using, on what platform?

> Now you have me worried...
> - Ubuntu 20.04
> - libedit, version 3.1-20191231-1

We've had troubles with libedit before :-(, and that particular release
is known to be a bit buggy [1].

I can reproduce a problem using HEAD (no patch needed) and Fedora 32's
libedit-3.1-32.20191231cvs.fc32.x86_64: if I type

    create subscription s connection foo <TAB>

then it happily completes "PUBLICATION", but if I type

    create subscription s connection 'foo' <TAB>

I just get beeps.

I do *not* see this misbehavior on a nearby FreeBSD 13.0 machine
with libedit 3.1.20210216,1 (which isn't even the latest version).
So it's a fixed-some-time-ago bug.  Given the symptoms, I wonder
if it isn't closely related to the original complaint at [1].

Anyway, the bottom line from our standpoint is going to be that
we can't put a test case like this one into the TAP test.  I recall
that getting 010_tab_completion.pl to pass everywhere was a huge
headache at the outset, so this conclusion doesn't surprise me
much.

            regards, tom lane

[1] http://gnats.netbsd.org/cgi-bin/query-pr-single.pl?number=54510



pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: unnesting multirange data types
Next
From: Andres Freund
Date:
Subject: Re: Why does bootstrap and later initdb stages happen via client?