Re: pgsql: Add putenv support for msvcrt from Visual Studio 2013 - Mailing list pgsql-hackers

From Christian Ullrich
Subject Re: pgsql: Add putenv support for msvcrt from Visual Studio 2013
Date
Msg-id 34dd7956-3324-0305-288d-edc7d56fba76@chrullrich.net
Whole thread Raw
In response to Re: pgsql: Add putenv support for msvcrt from Visual Studio 2013  (Magnus Hagander <magnus@hagander.net>)
Responses Re: [COMMITTERS] pgsql: Add putenv support for msvcrt from Visual Studio 2013  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
* Magnus Hagander wrote:

> On Sun, Apr 24, 2016 at 9:56 PM, Christian Ullrich <chris@chrullrich.net>
> wrote:
>
>> * Magnus Hagander wrote:
>>
>> Add putenv support for msvcrt from Visual Studio 2013
>> http://git.postgresql.org/pg/commitdiff/9f633b404cb3be6139f8dfdea00538489ffef9ab

>> Just noticed something. This DLL detection by name has never worked in
>> debug builds where the DLL names end in "d". Is that important?

> That's an interesting point.  I guess our release builds are never with
> debugging info - but could it make the buildfarm "wrong"?
>
> Fixing it should probably be as easy as trying each dll with the specified
> name and also with a "d" as a suffix?

I think so, yes.

Personally, I would have expected that at least the debug/release DLLs
of a single CRT version would somehow share their environment, but I
tried it and they don't.

--
Christian





pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: pgsql: Add putenv support for msvcrt from Visual Studio 2013
Next
From: Alexander Korotkov
Date:
Subject: Re: snapshot too old, configured by time