Re: Walker/mutator prototype. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Walker/mutator prototype.
Date
Msg-id 3374.1071443649@sss.pgh.pa.us
Whole thread Raw
In response to Walker/mutator prototype.  (Kurt Roeckx <Q@ping.be>)
List pgsql-hackers
Kurt Roeckx <Q@ping.be> writes:
> I'm trying to change all the walkers and mutators to have a more
> strict prototype.  I had to do this with lots of casts.

Forget it ;-).  There's a reason why they use a loose prototype,
and it's exactly what you just found: the notational penalty of
being strict vastly outweighs any possible benefit.

Arguably, given the need to cast everything to Node * or void *,
the tighter prototypes are contributing zero additional error
checking anyway.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Archives
Next
From: Andrew Dunstan
Date:
Subject: Re: [PATCHES] fork/exec patch