Re: pg_amcheck contrib application - Mailing list pgsql-hackers

From Mark Dilger
Subject Re: pg_amcheck contrib application
Date
Msg-id 32D4C61A-8FD6-4C22-A62D-5594D5B4CCE6@enterprisedb.com
Whole thread Raw
In response to Re: pg_amcheck contrib application  (Mark Dilger <mark.dilger@enterprisedb.com>)
Responses Re: pg_amcheck contrib application  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers

> On Apr 23, 2021, at 3:01 PM, Mark Dilger <mark.dilger@enterprisedb.com> wrote:
>
> I'll try to post something that accomplishes the changes to the reports that you are looking for.

The attached patch changes amcheck corruption reports as discussed upthread.  This patch is submitted for the v14
developmentcycle as a bug fix, per your complaint that the committed code generates reports sufficiently confusing to a
useras to constitute a bug. 

All other code refactoring and additional checks discussed upthread are reserved for the v15 development cycle and are
notincluded here. 

The minimal patch (not attached) that does not rename any variables is 135 lines.  Your patch was 159 lines.  The patch
(attached)which includes your variable renaming is 174 lines. 



—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




Attachment

pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: compute_query_id and pg_stat_statements
Next
From: David Christensen
Date:
Subject: Re: Issue in recent pg_stat_statements?