Re: TRUNCATE on foreign table - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: TRUNCATE on foreign table
Date
Msg-id 32055c4d-fc0e-fb4d-6c31-5a4d084e4fda@oss.nttdata.com
Whole thread Raw
In response to Re: TRUNCATE on foreign table  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: TRUNCATE on foreign table  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers

On 2021/04/23 19:56, Bharath Rupireddy wrote:
> On Fri, Apr 23, 2021 at 1:39 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>>> +    <para>
>>> +     Note that information about <literal>ONLY</literal> options specified
>>> +     in the original <command>TRUNCATE</command> command is not passed to
>>>
>>> I think it is not "information about", no? We just don't pass ONLY
>>> option  instead we skip it. IMO, we can say "Note that the ONLY option
>>> specified with a foreign table in the original TRUNCATE command is
>>> skipped and not passed to ExecForeignTruncate."
>>
>> Probably I still fail to understand your point.
>> But if "information about" is confusing, I'm ok to
>> remove that. Fixed.
> 
> A small typo in the docs patch: It is "are not passed to", instead of
> "is not passed to" since we used plural "options". "Note that the ONLY
> options specified in the original TRUNCATE command are not passed to"
> 
> +     Note that the <literal>ONLY</literal> options specified
>        in the original <command>TRUNCATE</command> command is not passed to

Thanks for the review! I fixed this.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Attachment

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: [bug?] Missed parallel safety checks, and wrong parallel safety
Next
From: Andres Freund
Date:
Subject: Re: A test for replay of regression tests