Re: Missing pfree in logical_heap_rewrite_flush_mappings() - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Missing pfree in logical_heap_rewrite_flush_mappings()
Date
Msg-id 31701.1398220657@sss.pgh.pa.us
Whole thread Raw
In response to Re: Missing pfree in logical_heap_rewrite_flush_mappings()  (Bruce Momjian <bruce@momjian.us>)
Responses Re: Missing pfree in logical_heap_rewrite_flush_mappings()  (Andres Freund <andres@2ndquadrant.com>)
List pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> I had to revert this patch.  It causes a failure in the
> /contrib/test_decoding regression test.

On closer inspection, it was simply pfree'ing the wrong pointer.

I fixed that and also undid the allocation in a different memory
context, which didn't seem to be a particularly good idea, unless
you've got a specific reason why CurrentMemoryContext would be the
wrong place for a transient allocation.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Missing pfree in logical_heap_rewrite_flush_mappings()
Next
From: Sergey Konoplev
Date:
Subject: Re: pg_upgrade and epoch