Postgres Pro
Downloads
Home   >   mailing lists

Re: Missing pfree in logical_heap_rewrite_flush_mappings() - Mailing list pgsql-hackers

From Bruce Momjian
Subject Re: Missing pfree in logical_heap_rewrite_flush_mappings()
Date
Msg-id 20140423022519.GA12697@momjian.us
Whole thread Raw
In response to Re: Missing pfree in logical_heap_rewrite_flush_mappings()  (Bruce Momjian <bruce@momjian.us>)
Responses Re: Missing pfree in logical_heap_rewrite_flush_mappings()
List pgsql-hackers
Tree view 
On Tue, Apr 22, 2014 at 06:05:53PM -0400, Bruce Momjian wrote:
> On Wed, Mar 26, 2014 at 06:29:38PM +0200, Ants Aasma wrote:
> > It seems to me that when flushing logical mappings to disk, each
> > mapping file leaks the buffer used to pass the mappings to XLogInsert.
> > Also, it seems consistent to allocate that buffer in the RewriteState
> > memory context. Patch attached.
> 
> Patch applied.

I had to revert this patch.  It causes a failure in the
/contrib/test_decoding regression test.


--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + Everyone has their own god. +

pgsql-hackers by date:

Previous
From: Sergey Burladyan
Date:
Subject: pg_upgrade and epoch
Next
From: Tom Lane
Date:
Subject: Re: Missing pfree in logical_heap_rewrite_flush_mappings()