Re: pgsql: Remove WITH OIDS support, change oid catalog column visibility. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pgsql: Remove WITH OIDS support, change oid catalog column visibility.
Date
Msg-id 31665.1546540842@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Remove WITH OIDS support, change oid catalog columnvisibility.  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Responses Re: pgsql: Remove WITH OIDS support, change oid catalog columnvisibility.  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
I noticed that this patch has broken restores of existing dump files:

psql:testbed.public.backup:82: ERROR:  unrecognized configuration parameter "default_with_oids"

Quite aside from the fact that this won't work if the user tries to
restore in single-transaction or no-error mode, this is really really
unhelpful because it's impossible to tell whether the error is
ignorable or not, except by digging through the dump file.

What you should do is restore that GUC, but add a check-hook that throws
an error for an attempt to set it to "true".

            regards, tom lane


pgsql-hackers by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: Logical decoding for operations on zheap tables
Next
From: Andrey Borodin
Date:
Subject: Re: GiST VACUUM