Re: pgsql: Remove WITH OIDS support, change oid catalog columnvisibility. - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: pgsql: Remove WITH OIDS support, change oid catalog columnvisibility.
Date
Msg-id 74aafd48-1a2a-37fb-aab8-ffaed70a2b0f@2ndquadrant.com
Whole thread Raw
In response to Re: pgsql: Remove WITH OIDS support, change oid catalog columnvisibility.  (Christoph Berg <myon@debian.org>)
Responses Re: pgsql: Remove WITH OIDS support, change oid catalog column visibility.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 21/11/2018 09:20, Christoph Berg wrote:
> Re: Andres Freund 2018-11-21 <E1gPG3j-0003cy-03@gemulon.postgresql.org>
>> The biggest user of WITH OID columns was postgres' catalog. This
>> commit changes all 'magic' oid columns to be columns that are normally
>> declared and stored.
> 
> postgres=# \d+ pg_class
> [...]
> Indexe:
>     "pg_class_oid_index" UNIQUE, btree (oid)
> 
> Now that oid is a proper column, shouldn't that be a PRIMARY KEY?
> (Just for the looks.)

This is an independent consideration.  There was nothing before that
prevented an index on an oid column from being a primary key that isn't
still there.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


pgsql-hackers by date:

Previous
From: "Iwata, Aya"
Date:
Subject: RE: libpq debug log
Next
From: Amit Langote
Date:
Subject: Re: speeding up planning with partitions