Re: pgsql: Fix page modification outside of critical section in GIN - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql: Fix page modification outside of critical section in GIN
Date
Msg-id 31240.1581267932@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Fix page modification outside of critical section in GIN  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Fix page modification outside of critical section in GIN  (Alexander Korotkov <a.korotkov@postgrespro.ru>)
List pgsql-committers
I wrote:
> Alexander Korotkov <akorotkov@postgresql.org> writes:
>> Fix page modification outside of critical section in GIN

> I happened to notice, while reviewing stuff for the release notes,
> that this patch does not do what the commit message says.  The
> previous code modified the pd_prune_xid of the "dBuffer" page,
> but now it's modifying the pd_prune_xid of the "lBuffer" page.
> Is that actually correct?

Since we're rapidly approaching the wrap deadline for this week's
releases, I took it upon myself to review this code more carefully,
and concluded that indeed it isn't correct.  I pushed a fix that
moves the GinPageSetDeleteXid call again.

            regards, tom lane



pgsql-committers by date:

Previous
From: Tom Lane
Date:
Subject: pgsql: Store the deletion horizon XID for a deleted GIN page on the rig
Next
From: Tom Lane
Date:
Subject: pgsql: Release notes for 12.2, 11.7, 10.12, 9.6.17, 9.5.21, 9.4.26.