Re: pgsql: Remove --disable-spinlocks. - Mailing list pgsql-committers

From Heikki Linnakangas
Subject Re: pgsql: Remove --disable-spinlocks.
Date
Msg-id 310f4005-91d7-42b2-ac70-92624260dd28@iki.fi
Whole thread Raw
In response to pgsql: Remove --disable-spinlocks.  (Thomas Munro <tmunro@postgresql.org>)
Responses Re: pgsql: Remove --disable-spinlocks.
List pgsql-committers
On 30/07/2024 14:03, Thomas Munro wrote:
> Remove --disable-spinlocks.

Sorry, spotted this only now:

> --- a/src/backend/postmaster/launch_backend.c
> +++ b/src/backend/postmaster/launch_backend.c
> @@ -108,9 +108,7 @@ typedef struct
>  #ifdef USE_INJECTION_POINTS
>     struct InjectionPointsCtl *ActiveInjectionPoints;
>  #endif
> -#ifndef HAVE_SPINLOCKS
>     PGSemaphore *SpinlockSemaArray;
> -#endif
>     int         NamedLWLockTrancheRequests;
>     NamedLWLockTranche *NamedLWLockTrancheArray;
>     LWLockPadded *MainLWLockArray;

The SpinLockSemaArray field should be completely completely, nut just 
the #ifndef guard around it.

-- 
Heikki Linnakangas
Neon (https://neon.tech)




pgsql-committers by date:

Previous
From: Thomas Munro
Date:
Subject: pgsql: Require compiler barrier support.
Next
From: Thomas Munro
Date:
Subject: pgsql: Remove useless member of BackendParameters.