pgsql: Require compiler barrier support. - Mailing list pgsql-committers

From Thomas Munro
Subject pgsql: Require compiler barrier support.
Date
Msg-id E1sYkdl-001sbr-Hg@gemulon.postgresql.org
Whole thread Raw
List pgsql-committers
Require compiler barrier support.

Previously we had a fallback implementation of pg_compiler_barrier()
that called an empty function across a translation unit boundary so the
compiler couldn't see what it did.  That shouldn't be needed on any
current systems, and might not even work with a link time optimizer.
Since we now require compiler-specific knowledge of how to implement
atomics, we should also know how to implement compiler barriers on a
hypothetical new system.

Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Suggested-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/721bf39a-ed8a-44b0-8b8e-be3bd81db748%40technowledgy.de
Discussion: https://postgr.es/m/3351991.1697728588%40sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a011dc399cc82be07326c89c926bd5880160b1ba

Modified Files
--------------
src/backend/port/atomics.c          |  8 --------
src/include/port/atomics.h          |  3 +++
src/include/port/atomics/fallback.h | 15 ---------------
3 files changed, 3 insertions(+), 23 deletions(-)


pgsql-committers by date:

Previous
From: Peter Eisentraut
Date:
Subject: pgsql: pg_createsubscriber: Remove obsolete comment
Next
From: Heikki Linnakangas
Date:
Subject: Re: pgsql: Remove --disable-spinlocks.