Re: GiST penalty functions [PoC] - Mailing list pgsql-hackers

From Tom Lane
Subject Re: GiST penalty functions [PoC]
Date
Msg-id 3091.1473334659@sss.pgh.pa.us
Whole thread Raw
In response to Re: GiST penalty functions [PoC]  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: GiST penalty functions [PoC]  (Andrew Borodin <borodin@octonica.com>)
List pgsql-hackers
Heikki Linnakangas <hlinnaka@iki.fi> writes:
> BTW, I would be OK with the bit-twiddling hack, if we had an autoconf 
> check for IEEE 754 floats, and a graceful fallback for other systems. 

I would still object to the version submitted, on the grounds of the
compiler warnings it causes.  Possibly those could be avoided with
a union, though; Float4GetDatum doesn't produce such warnings.

BTW, would someone explain to me why using a float here will not
fail catastrophically for inputs outside the range of float?
Cubes are based on doubles, not floats.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Victor Wagner
Date:
Subject: Re: Patch: Implement failover on libpq connect level.
Next
From: Pavel Stehule
Date:
Subject: Re: \timing interval