Hello hackers,
19.04.2020 13:37, Tom Lane wrote:
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
The HEAPDEBUGALL define has been broken since PG12 due to tableam changes. Should we just remove this? It doesn't look very useful. It's been around since Postgres95.
If we opt for removing: PG12 added an analogous HEAPAMSLOTDEBUGALL (which still compiles correctly). Would we want to keep that?
+1 for removing both. There are a lot of such debug "features"
in the code, and few of them are worth anything IME.
To the point, I've tried to use HAVE_ALLOCINFO on master today and it failed too:
$ CPPFLAGS="-DHAVE_ALLOCINFO" ./configure --enable-tap-tests --enable-debug --enable-cassert >/dev/null && make -j16 >/dev/null
generation.c: In function ‘GenerationAlloc’:
generation.c:191:11: error: ‘GenerationContext {aka struct GenerationContext}’ has no member named ‘name’
(_cxt)->name, (_chunk), (_chunk)->size)
^
generation.c:386:3: note: in expansion of macro ‘GenerationAllocInfo’
GenerationAllocInfo(set, chunk);
^~~~~~~~~~~~~~~~~~~
generation.c:191:11: error: ‘GenerationContext {aka struct GenerationContext}’ has no member named ‘name’
(_cxt)->name, (_chunk), (_chunk)->size)
^
generation.c:463:2: note: in expansion of macro ‘GenerationAllocInfo’
GenerationAllocInfo(set, chunk);
^~~~~~~~~~~~~~~~~~~
Best regards,
Alexander
