Re: pgsql: Add contrib/pg_walinspect. - Mailing list pgsql-hackers

I wrote:
> Thomas Munro <thomas.munro@gmail.com> writes:
>> BTW If you had your local change from debug.patch (upthread), that'd
>> defeat the patch.  I mean this:

>> +        if(!*errormsg)
>> +          *errormsg = "decode_queue_head is null";

> Oh!  Okay, I'll retry without that.

I've now done several runs with your patch and not seen the test failure.
However, I think we ought to rethink this API a bit rather than just
apply the patch as-is.  Even if it were documented, relying on
errormsg = NULL to mean something doesn't seem like a great plan.

            regards, tom lane