C language function dump problem - Mailing list pgsql-hackers

From Philip Warner
Subject C language function dump problem
Date
Msg-id 3.0.5.32.20000709205007.02134100@mail.rhyme.com.au
Whole thread Raw
Responses Re: C language function dump problem
List pgsql-hackers
It seems some code disappeared from pg_dump.c between 7.0.2 and current, I
think in the following revisions:

revision 1.148
date: 2000/05/28 20:34:52;  author: tgl;  state: Exp;  lines: +21 -42
Miscellaneous cleanups of places that needed to account for new
pg_language entries.
----------------------------
revision 1.147
date: 2000/04/14 01:34:24;  author: tgl;  state: Exp;  lines: +2 -2
Another static-vs-not-static error.

The code is:

...in dumpOneFunc....
   if (finfo[i].dumped)       return;   else       finfo[i].dumped = 1;
   /* becomeUser(fout, finfo[i].usename); */
   if (finfo[i].lang == INTERNALlanguageId)   {       func_def = finfo[i].prosrc;       strcpy(func_lang, "INTERNAL");
}   else if (finfo[i].lang == ClanguageId)   {       func_def = finfo[i].probin;       strcpy(func_lang, "C");   }
elseif (finfo[i].lang == SQLlanguageId)   {       func_def = finfo[i].prosrc;       strcpy(func_lang, "SQL");   }
else  {
 

and without this code, the dumps for plpgsql call handlers do not work (at
least for me). It may be that I have messed something up in the code, but I
don't think so.

Any light you can shed on this would be great.

P.S. The specific problem is that it now uses plsrc as the definition for
all functions, whereas the (C language) plpgsql call handler requires plbin
to be used.


----------------------------------------------------------------
Philip Warner                    |     __---_____
Albatross Consulting Pty. Ltd.   |----/       -  \
(A.C.N. 008 659 498)             |          /(@)   ______---_
Tel: (+61) 0500 83 82 81         |                 _________  \
Fax: (+61) 0500 83 82 82         |                 ___________ |
Http://www.rhyme.com.au          |                /           \|                                |    --________--
PGP key available upon request,  |  /
and from pgp5.ai.mit.edu:11371   |/


pgsql-hackers by date:

Previous
From: Karel Zak
Date:
Subject: Re: crypt and MD5 - still not wanted
Next
From: Philip Warner
Date:
Subject: Bug list?