Re: Option to not use ringbuffer in VACUUM, using it in failsafe mode - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Option to not use ringbuffer in VACUUM, using it in failsafe mode
Date
Msg-id 2EE2FBAC-A190-45A4-8381-F51CCB61A037@yesql.se
Whole thread Raw
In response to Re: Option to not use ringbuffer in VACUUM, using it in failsafe mode  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Option to not use ringbuffer in VACUUM, using it in failsafe mode
List pgsql-hackers
> On 26 Apr 2023, at 13:26, David Rowley <dgrowleyml@gmail.com> wrote:
> On Wed, 26 Apr 2023, 8:48 pm Masahiko Sawada, <sawada.mshk@gmail.com <mailto:sawada.mshk@gmail.com>> wrote:

> It works but I think we might want to add the unit kB for
> understandability and consistency with other GUC_UNIT_KB parameters.
> I've attached a small patch that adds the unit and aligns the indent
> of the comments to the perimeter parameters.
>
> I'm not currently able to check, but if work_mem has a unit in the sample conf then I agree that
vacuum_buffer_usage_limitshould too. 

+1 work_mem and all other related options in this section has a unit in the
sample conf so adding this makes sense.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Find dangling membership roles in pg_dumpall
Next
From: Robert Haas
Date:
Subject: Re: pg_stat_io for the startup process