Postgres Pro
Downloads
Home   >   mailing lists

Re: Find dangling membership roles in pg_dumpall - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Find dangling membership roles in pg_dumpall
Date
Msg-id 34D07177-7F22-4CBC-B068-437C62F017FD@yesql.se
Whole thread Raw
In response to Re: Find dangling membership roles in pg_dumpall  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: Find dangling membership roles in pg_dumpall
List pgsql-hackers
Tree view 
> On 26 Apr 2023, at 13:02, Daniel Gustafsson <daniel@yesql.se> wrote:
>> On 26 Apr 2023, at 12:18, Andreas 'ads' Scherbaum <ads@pgug.de> wrote:

>> The attached patch fixes this problem, and updates prev_remaining inside
>> the loop.
>
> Nice catch, that indeed seems like a proper fix.  This was introduced in
> ce6b672e44 and so doesn't need a backpatch.

Pushed, but without the comment extension as I felt the existing comment aptly
discussed the codepath. Thanks!

--
Daniel Gustafsson

pgsql-hackers by date:

Previous
From: Aleksander Alekseev
Date:
Subject: Re: [PATCH] Extend the length of BackgroundWorker.bgw_library_name
Next
From: Daniel Gustafsson
Date:
Subject: Re: Option to not use ringbuffer in VACUUM, using it in failsafe mode