Re: meson: Non-feature feature options - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: meson: Non-feature feature options
Date
Msg-id 2EC91B34-3E08-4D97-B98C-487BB85B131D@yesql.se
Whole thread Raw
In response to Re: meson: Non-feature feature options  (Nazir Bilal Yavuz <byavuz81@gmail.com>)
List pgsql-hackers
> On 9 Mar 2023, at 15:12, Nazir Bilal Yavuz <byavuz81@gmail.com> wrote:
>
> Hi,
>
> On Thu, 9 Mar 2023 at 16:54, Daniel Gustafsson <daniel@yesql.se> wrote:
>>
>>> On 9 Mar 2023, at 14:45, Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:
>>
>>> How about we just hardcode "openssl" here instead?  We could build that array dynamically, of course, but maybe we
leavethat until we actually have a need? 
>>
>> At least for 16 keeping it hardcoded is an entirely safe bet so +1 for leaving
>> additional complexity for when needed.
>
> We already have the 'ssl_library' variable. Can't we use that instead
> of hardcoding 'openssl'? e.g:
>
> summary(
>  {
>    'ssl': ssl.found() ? [ssl, '(@0@)'.format(ssl_library)] : ssl,
>  },
>  section: 'External libraries',
>  list_sep: ', ',
> )
>
> And it will output:
> ssl                    : YES 3.0.8, (openssl)
>
> I don't think that using 'ssl_library' will increase the complexity.

That seems like a good idea.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: postgres_fdw, dblink, and CREATE SUBSCRIPTION security
Next
From: Robert Haas
Date:
Subject: Re: postgres_fdw, dblink, and CREATE SUBSCRIPTION security