Re: xlog location arithmetic - Mailing list pgsql-hackers

From Tom Lane
Subject Re: xlog location arithmetic
Date
Msg-id 29655.1331307462@sss.pgh.pa.us
Whole thread Raw
In response to Re: xlog location arithmetic  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: xlog location arithmetic  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Fri, Mar 9, 2012 at 9:55 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Actually ... now that I look at it, isn't it completely bogus to be
>> using numeric for the result of pg_xlog_location_diff?

> rhaas=# select pg_xlog_location_diff('ffffffff/0', '0/0')::int8;
> ERROR:  bigint out of range

Oh ... I see my mistake.  I was looking at this:
/* * result = XLogFileSize * (xlogid1 - xlogid2) + xrecoff1 - xrecoff2 */

and confusing XLogFileSize with XLogSegSize.  Not the best choice of
names.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Kohei KaiGai
Date:
Subject: Re: elegant and effective way for running jobs inside a database
Next
From: Tom Lane
Date:
Subject: Re: pg_upgrade and umask