Re: lots of unused variable warnings in assert-free builds - Mailing list pgsql-hackers

From Tom Lane
Subject Re: lots of unused variable warnings in assert-free builds
Date
Msg-id 29618.1332270242@sss.pgh.pa.us
Whole thread Raw
In response to Re: lots of unused variable warnings in assert-free builds  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: lots of unused variable warnings in assert-free builds
List pgsql-hackers
Peter Eisentraut <peter_e@gmx.net> writes:
> As you can see, pgindent adds whitespace on top of #ifdef
> USE_ASSERT_CHECKING, and messes up the vertical alignment of variable
> definitions that contain extra attributes.

Hm.  I bet it thinks that PG_USED_FOR_ASSERTS_ONLY is the variable name,
which means that the behavior might be more exciting for multi-word type
names (for instance "struct foo" or "volatile int *".  Could you check
a few cases like that?

> All things considered, I like the PG_USED_FOR_ASSERTS_ONLY solution best.

I agree, unless the more complicated cases go further off the rails.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: lots of unused variable warnings in assert-free builds
Next
From: Thom Brown
Date:
Subject: Re: Command Triggers patch v18