Re: txid strtoull fix - Mailing list pgsql-patches

From Tom Lane
Subject Re: txid strtoull fix
Date
Msg-id 29587.1191875249@sss.pgh.pa.us
Whole thread Raw
In response to txid strtoull fix  ("Marko Kreen" <markokr@gmail.com>)
Responses Re: txid strtoull fix  ("Marko Kreen" <markokr@gmail.com>)
List pgsql-patches
"Marko Kreen" <markokr@gmail.com> writes:
> I noticed strtoull() causes problems on some buildfarm
> machines.  As a fix I propose small str2num function inside
> txid.c itself.  Main reason is that the txid actually does
> not need fully-featured strtoull (radixes, whitespace skipping).

Seems like a sane solution to me --- applied.

(Note that your overflow test didn't actually work; AFAIK there
really isn't any decent solution other than dividing at each step.)

            regards, tom lane

pgsql-patches by date:

Previous
From: "Marko Kreen"
Date:
Subject: txid strtoull fix
Next
From: "Marko Kreen"
Date:
Subject: Re: txid strtoull fix