Re: txid strtoull fix - Mailing list pgsql-patches

From Marko Kreen
Subject Re: txid strtoull fix
Date
Msg-id e51f66da0710081351l5083e34cp6c1cd770df4f439@mail.gmail.com
Whole thread Raw
In response to Re: txid strtoull fix  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: txid strtoull fix
List pgsql-patches
On 10/8/07, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> "Marko Kreen" <markokr@gmail.com> writes:
> > I noticed strtoull() causes problems on some buildfarm
> > machines.  As a fix I propose small str2num function inside
> > txid.c itself.  Main reason is that the txid actually does
> > not need fully-featured strtoull (radixes, whitespace skipping).
>
> Seems like a sane solution to me --- applied.
>
> (Note that your overflow test didn't actually work; AFAIK there
> really isn't any decent solution other than dividing at each step.)

Hmm.  It did seem to work here.  Just in case I peeked into
FreeBSD strtoull() and this patch imitates their method.

This also seems to work, but please review, I'm don't feel
very sharp anymore...

--
marko

Attachment

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: txid strtoull fix
Next
From: Alvaro Herrera
Date:
Subject: Re: [HACKERS] Add function for quote_qualified_identifier?