Re: pg_get_viewdef 7.4 parentheses - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_get_viewdef 7.4 parentheses
Date
Msg-id 2940.1049844434@sss.pgh.pa.us
Whole thread Raw
In response to pg_get_viewdef 7.4 parentheses  (Andreas Pflug <Andreas.Pflug@web.de>)
List pgsql-hackers
Andreas Pflug <Andreas.Pflug@web.de> writes:
> While implementing a function for making view definitions look prettier  
> in pgadmin3, I had a look at ruleutils.c to examine why there are tons 
> of parentheses coming out of pg_get_viewdef. I believe that some are 
> really not needed.

The difficulty is to know which ones *are* needed in complex
expressions.  If you think that any of them are always unnecessary,
you haven't thought hard enough.  For example:

> - get_rule_expr, for CASES T_RelabelType and T_CoerceToDomain. The cast 
> is always bound to the near left variable, so it can be left out.

What if the argument isn't just a variable?
        regards, tom lane



pgsql-hackers by date:

Previous
From: Andrew Sullivan
Date:
Subject: Re: Anyone working on better transaction locking?
Next
From: Shinji Teragaito
Date:
Subject: Re: HP-UX 11.22 (IA64) IPF Patch for PostgreSQL 7.3.2