Re: bug when apply fast default mechanism for adding new column over domain with default value - Mailing list pgsql-hackers

From Tom Lane
Subject Re: bug when apply fast default mechanism for adding new column over domain with default value
Date
Msg-id 2901599.1740811424@sss.pgh.pa.us
Whole thread Raw
In response to bug when apply fast default mechanism for adding new column over domain with default value  (jian he <jian.universality@gmail.com>)
List pgsql-hackers
jian he <jian.universality@gmail.com> writes:
> then I think I found a bug for applying fast default over domain with
> default value.

Yeah, that's definitely a bug: it worked correctly in versions
before we invented the attmissingval mechanism.

> column b type is domain int_domain3, which has a constraint.
> As a result, adding column b triggers a table rewrite, ensuring the
> domain default value is successfully applied.

I do not believe that case should require a table rewrite.
Both the default and the check constraint are immutable,
so we ought to be able to apply the check once and then
use the default as the attmissingval.

> Attach a patch to fix this issue by cause it to table rewrite.

I see no attached patch, but in any case forcing a table rewrite
seems like the wrong direction...

            regards, tom lane



pgsql-hackers by date:

Previous
From: "Shankaran, Akash"
Date:
Subject: RE: SIMD optimization for list_sort
Next
From: Pavel Stehule
Date:
Subject: Re: Re: proposal: schema variables