Postgres Pro
Downloads
Home   >   mailing lists

Re: psql :: support for \ev viewname and \sv viewname - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: psql :: support for \ev viewname and \sv viewname
Date
Msg-id 28e80f8e-3ec0-1505-6b9a-5b55ef1b8eae@2ndquadrant.com
Whole thread Raw
In response to Re: psql :: support for \ev viewname and \sv viewname  (Dean Rasheed <dean.a.rasheed@gmail.com>)
Responses Re: psql :: support for \ev viewname and \sv viewname  (Dean Rasheed <dean.a.rasheed@gmail.com>)
List pgsql-hackers
Tree view 
On 5/2/16 8:53 AM, Dean Rasheed wrote:
> Here are updated patches doing that --- the first moves
> fmtReloptionsArray() from pg_dump.c to fe_utils/string_utils.c so that
> it can be shared by pg_dump and psql, and renames it to
> appendReloptionsArray(). The second patch fixes the actual psql bug.

This looks reasonable.

I would change appendReloptionsArrayAH() to a function and keep AH as 
the first argument (similar to other functions that take such a handle).

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Kevin Grittner
Date:
Subject: Re: old_snapshot_threshold's interaction with hash index
Next
From: Robert Haas
Date:
Subject: what to revert