Re: Online enabling of checksums - Mailing list pgsql-hackers

From Andrey Borodin
Subject Re: Online enabling of checksums
Date
Msg-id 28C6DD2F-F543-4AB9-B247-A88E4A91F605@yandex-team.ru
Whole thread Raw
In response to Re: Online enabling of checksums  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Online enabling of checksums
List pgsql-hackers
Hi, Magus!

> 25 февр. 2018 г., в 21:17, Magnus Hagander <magnus@hagander.net> написал(а):
>
> PFA an updated patch that adds this, and also fixes the problem in pg_verify_checksums spotted by Michael Banck.

I had to ALLOW_CONNECTIONS to template0 to make it work
postgres=# 2018-02-27 21:29:05.993 +05 [57259] ERROR:  Database template0 does not allow connections.
Is it a problem with my installation or some regression in the patch?

2018-02-27 21:40:47.132 +05 [57402] HINT:  either disable or enable checksums by calling the
pg_data_checksums_enable()/disable()functions 
Function names are wrong in this hint: pg_enable_data_checksums()

The code is nice and clear. One minor spot in the comment
>This option can only _be_ enabled when data checksums are enabled.

Is there any way we could provide this functionality for previous versions (9.6,10)? Like implement utility for offline
checksumenabling, without WAL-logging, surely. 


Thanks for the patch!

Best regards, Andrey Borodin.

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: prokind column (was Re: [HACKERS] SQL procedures)
Next
From: Alexander Korotkov
Date:
Subject: Re: [HACKERS] GUC for cleanup indexes threshold.