Re: Allows for commands to be processed iteractively - Mailing list pgsql-patches

From Tom Lane
Subject Re: Allows for commands to be processed iteractively
Date
Msg-id 28498.1014998430@sss.pgh.pa.us
Whole thread Raw
In response to Allows for commands to be processed iteractively  (Fernando Nasser <fnasser@redhat.com>)
List pgsql-patches
Fernando Nasser <fnasser@redhat.com> writes:
>         Allows for some commands to be processed iteractively.

This patch seems to be missing quite a lot, like the node struct
definition and backend/nodes/*.c support for CreateSchemaStmt.
Perhaps your intention was not to introduce that yet, but in that
case I'd suggest not adding any sign of it in this patch.

More to the point, though, what is the reason for restructuring
pg_exec_query_string this way?  The patch doesn't make any sense
to me as presented.  I should think that any effort needed for
CREATE SCHEMA would be over in parser/analyze.c; restructuring
pg_exec_query_string isn't going to help.

            regards, tom lane

pgsql-patches by date:

Previous
From: Fernando Nasser
Date:
Subject: Re: Allows for commands to be processed iteractively
Next
From: Tom Lane
Date:
Subject: Re: Adds the parsing of a CREATE SCHEMA statement