Re: Win32 defines - Mailing list pgsql-patches

From Tom Lane
Subject Re: Win32 defines
Date
Msg-id 28318.1049381262@sss.pgh.pa.us
Whole thread Raw
In response to Win32 defines  (Bruce Momjian <pgman@candle.pha.pa.us>)
Responses Re: Win32 defines  (Bruce Momjian <pgman@candle.pha.pa.us>)
List pgsql-patches
Bruce Momjian <pgman@candle.pha.pa.us> writes:
> This adds some Win32 defines to cygwin defines --- this isn't all of
> them, but it is most.

You got at least some of these backwards, eg

> ! #ifndef __CYGWIN__

> ! #if defined(__CYGWIN__) || defined(WIN32)

Also, are you sure that it's really appropriate to handle the native
port like Cygwin in each of these cases?  Maybe so, I didn't look...

            regards, tom lane


pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: system() patch for Win32
Next
From: Peter Eisentraut
Date:
Subject: Re: Win32 path patch