Re: Win32 defines - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: Win32 defines
Date
Msg-id 200304042048.h34KmTN00295@candle.pha.pa.us
Whole thread Raw
In response to Re: Win32 defines  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Win32 defines
List pgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman@candle.pha.pa.us> writes:
> > This adds some Win32 defines to cygwin defines --- this isn't all of
> > them, but it is most.
>
> You got at least some of these backwards, eg
>
> > ! #ifndef __CYGWIN__
>
> > ! #if defined(__CYGWIN__) || defined(WIN32)

Thanks.  Fixed.  I reviewed them all, but hacked at this one after
checking.

> Also, are you sure that it's really appropriate to handle the native
> port like Cygwin in each of these cases?  Maybe so, I didn't look...

I am goiing to back off some of these until it is compiled on Win32 ---
I am not positive if some of these are cygwin-specific changes and which
are Win32 also.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073


pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: system() patch for Win32
Next
From: Neil Conway
Date:
Subject: Re: Win32 defines