Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific
Date
Msg-id 2823519.1687137059@sss.pgh.pa.us
Whole thread Raw
In response to Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific  (Michael Paquier <michael@paquier.xyz>)
Responses Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific
List pgsql-hackers
Tree view 
Michael Paquier <michael@paquier.xyz> writes:
> Another thing that I was wondering, though..  Do you think that there
> would be an argument in being stricter in the hstore code regarding
> the handling of multi-byte characters with some checks based on
> IS_HIGHBIT_SET() when parsing the keys and values?

What have you got in mind?  We should already have validated encoding
correctness before the text ever gets to hstore_in, and I'm not clear
what additional checks would be useful.

            regards, tom lane

pgsql-hackers by date:

Previous
From: jian he
Date:
Subject: Re: Do we want a hashset type?
Next
From: Masahiko Sawada
Date:
Subject: Re: Subscription statistics are not dropped at DROP SUBSCRIPTION in some cases