Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific
Date
Msg-id ZJFA2hpiuOmGuE6N@paquier.xyz
Whole thread Raw
In response to Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [PATCH] hstore: Fix parsing on Mac OS X: isspace() is locale specific
List pgsql-hackers
Tree view 
On Sun, Jun 18, 2023 at 09:10:59PM -0400, Tom Lane wrote:
> What have you got in mind?  We should already have validated encoding
> correctness before the text ever gets to hstore_in, and I'm not clear
> what additional checks would be useful.

I was staring at the hstore parsing code and got the impression that
multi-byte character handling could be improved, but looking closer it
seems that I got that wrong.  Apologies for the noise.
--
Michael
Attachment

pgsql-hackers by date:

Previous
From: "Joel Jacobson"
Date:
Subject: Re: Do we want a hashset type?
Next
From: Will Mortensen
Date:
Subject: [PATCH] doc: fix markup indentation in MVCC