Re: pgsql: Add pg_partition_root to display top-most parent of apartition - Mailing list pgsql-committers

From Amit Langote
Subject Re: pgsql: Add pg_partition_root to display top-most parent of apartition
Date
Msg-id 27e4501a-ae56-94e4-1524-d509f048d61c@lab.ntt.co.jp
Whole thread Raw
In response to Re: [Suspect SPAM] Re: pgsql: Add pg_partition_root to displaytop-most parent of a partition  (Michael Paquier <michael@paquier.xyz>)
Responses Re: pgsql: Add pg_partition_root to display top-most parent of apartition
List pgsql-committers
On 2019/03/22 13:12, Michael Paquier wrote:
> On Fri, Mar 22, 2019 at 01:09:23PM +0900, Amit Langote wrote:
>>      /* Fetch the top-most parent */
>>      ancestors = get_partition_ancestors(relid);
>>
>> Maybe, the patch should update this comment to say "Fetch the list of
>> ancestors".
> 
> Perhaps so.  Note that actually the list is fetched to grab the
> top-most parent from it, so it sort of makes sense?

It looked fine before, but the new lines added by patch makes it look
wrong/misplaced somehow.

Thanks,
Amit



pgsql-committers by date:

Previous
From: Amit Langote
Date:
Subject: Re: pgsql: Add pg_partition_root to display top-most parent of apartition
Next
From: Michael Paquier
Date:
Subject: Re: pgsql: Add pg_partition_root to display top-most parent of apartition