Re: [Suspect SPAM] Re: pgsql: Add pg_partition_root to displaytop-most parent of a partition - Mailing list pgsql-committers

From Michael Paquier
Subject Re: [Suspect SPAM] Re: pgsql: Add pg_partition_root to displaytop-most parent of a partition
Date
Msg-id 20190322041225.GS20192@paquier.xyz
Whole thread Raw
In response to Re: [Suspect SPAM] Re: pgsql: Add pg_partition_root to displaytop-most parent of a partition  (Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>)
Responses Re: pgsql: Add pg_partition_root to display top-most parent of apartition
List pgsql-committers
On Fri, Mar 22, 2019 at 01:09:23PM +0900, Amit Langote wrote:
>      /* Fetch the top-most parent */
>      ancestors = get_partition_ancestors(relid);
>
> Maybe, the patch should update this comment to say "Fetch the list of
> ancestors".

Perhaps so.  Note that actually the list is fetched to grab the
top-most parent from it, so it sort of makes sense?

> What does "listed partition" mean?  Maybe, you mean "If the input
> relation..."?  How about write this as:

Input relation sounds better.
--
Michael

Attachment

pgsql-committers by date:

Previous
From: Amit Langote
Date:
Subject: Re: [Suspect SPAM] Re: pgsql: Add pg_partition_root to displaytop-most parent of a partition
Next
From: Amit Langote
Date:
Subject: Re: pgsql: Add pg_partition_root to display top-most parent of apartition