Re: canceling query - Mailing list pgsql-hackers-win32

From Tom Lane
Subject Re: canceling query
Date
Msg-id 27717.1082402371@sss.pgh.pa.us
Whole thread Raw
In response to Re: canceling query  ("Magnus Hagander" <mha@sollentuna.net>)
List pgsql-hackers-win32
"Magnus Hagander" <mha@sollentuna.net> writes:
> I beleive the fix needs to be in backend/utils/elog.c, function
> useful_strerror(). Unless someone either tells me that's the wrong place
> or beats me to it, I'll try to get a patch done for this soonest.

Sounds reasonable.  Better look also at errcode_for_socket_access() and
other places that check for particular errno values.

While you are at it you might want to make sure there aren't any other
unprotected strerror() calls in the backend.  At one time we had a fair
number of places with code like

    elog("barf: %s", strerror(errno));

and I'm not sure if all of them have gotten turned into %m or not.

            regards, tom lane

pgsql-hackers-win32 by date:

Previous
From: "Magnus Hagander"
Date:
Subject: Re: canceling query
Next
From: "Magnus Hagander"
Date:
Subject: Re: canceling query