Re: [HACKERS] Reversed sync check in pg_receivewal - Mailing list pgsql-hackers

From Tom Lane
Subject Re: [HACKERS] Reversed sync check in pg_receivewal
Date
Msg-id 27528.1491916785@sss.pgh.pa.us
Whole thread Raw
In response to [HACKERS] Reversed sync check in pg_receivewal  (Magnus Hagander <magnus@hagander.net>)
Responses Re: [HACKERS] Reversed sync check in pg_receivewal  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> Attached patch reverses the check, and adds a failure message. I'd
> appreciate a quick review in case I have the logic backwards in my head...

I think the patch is correct, but if there's any documentation of the
walmethod APIs that would allow one to assert which side of the API got
this wrong, I sure don't see it.  Would it be unreasonable to insist
on some documentation around that?
        regards, tom lane



pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [HACKERS] dropping a partition may cause deadlock
Next
From: Álvaro Hernández Tortosa
Date:
Subject: Re: [HACKERS] Some thoughts about SCRAM implementation