Re: implicit declaration of datumIsEqual in parse_coerce.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: implicit declaration of datumIsEqual in parse_coerce.c
Date
Msg-id 27483.1586294218@sss.pgh.pa.us
Whole thread Raw
In response to implicit declaration of datumIsEqual in parse_coerce.c  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
Responses Re: implicit declaration of datumIsEqual in parse_coerce.c  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
> Not sure what changed, but I'm seeing this failure:

> parse_coerce.c: In function ‘coerce_type’:
> parse_coerce.c:345:9: warning: implicit declaration of function ‘datumIsEqual’ [-Wimplicit-function-declaration]
>    345 |    if (!datumIsEqual(newcon->constvalue, val2, false, newcon->constlen))
>        |         ^~~~~~~~~~~~

That's inside "#ifdef RANDOMIZE_ALLOCATED_MEMORY", which probably
explains why most of us aren't seeing it.  My guess is somebody
removed an #include without realizing that this chunk of code
needed it.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: [HACKERS] make async slave to wait for lsn to be replayed
Next
From: Tom Lane
Date:
Subject: Re: proposal \gcsv