implicit declaration of datumIsEqual in parse_coerce.c - Mailing list pgsql-hackers

From Tomas Vondra
Subject implicit declaration of datumIsEqual in parse_coerce.c
Date
Msg-id 20200407205436.pyjhddw5bn5upvsu@development
Whole thread Raw
Responses Re: implicit declaration of datumIsEqual in parse_coerce.c
List pgsql-hackers
Hi,

Not sure what changed, but I'm seeing this failure:

parse_coerce.c: In function ‘coerce_type’:
parse_coerce.c:345:9: warning: implicit declaration of function ‘datumIsEqual’ [-Wimplicit-function-declaration]
   345 |    if (!datumIsEqual(newcon->constvalue, val2, false, newcon->constlen))
       |         ^~~~~~~~~~~~

Not sure if this because of compiler version (I'm on gcc 9.2.1) or
something else - I don't see any obvious changes to relevant parts of
the code, but I haven't dug too much.

Simply including 'utils/datum.h' resolves the issue.


regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace onthe fly
Next
From: Alexander Korotkov
Date:
Subject: Re: [HACKERS] make async slave to wait for lsn to be replayed