Re: Weird...but correct? - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Weird...but correct?
Date
Msg-id 27395.1090853216@sss.pgh.pa.us
Whole thread Raw
In response to Weird...but correct?  (Christopher Kings-Lynne <chriskl@familyhealth.com.au>)
List pgsql-hackers
Christopher Kings-Lynne <chriskl@familyhealth.com.au> writes:
> It's bizarre how you can comment on columns in composite types!
> CREATE TYPE test (a int4, b int4);
> COMMENT ON COLUMN test.a IS 'A column';

And not only that, but:

regression=# \d+ testComposite type "public.test"Column |  Type   | Description
--------+---------+-------------a      | integer | A columnb      | integer |

> Seems harmless, but should we allow it?

Why not?

> Shall I fix pg_dump?

Yes please, if it doesn't seem outlandishly hard.  (From memory it might
just be adding a subroutine call to dumpType...)
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: storage engine , mysql syntax CREATE TABLE t (i INT)
Next
From: Tom Lane
Date:
Subject: Re: Triggers on TRUNCATE?