Re: Another dead configure test - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Another dead configure test
Date
Msg-id 2695333.1660846846@sss.pgh.pa.us
Whole thread Raw
In response to Re: Another dead configure test  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Andres Freund <andres@anarazel.de> writes:
> On 2022-08-18 13:00:28 -0400, Tom Lane wrote:
>> I wondered about that, but we do need TCL_SHARED_BUILD in configure
>> itself, and the PGAC_EVAL_TCLCONFIGSH macro is going to AC_SUBST it.
>> We could remove the line in Makefile.global but I don't think that
>> buys much, and it might be more confusing not less so.

>> From the meson-generates-Makefile.global angle I like fewer symbols that have
> to be considered in Makefile.global.in :). But even leaving that aside, I
> think it's clearer to not have things in Makefile.global if they're not used.

> But it's obviously not important.

Yeah, I'm not excited about it either way --- feel free to change
if you'd rather.

            regards, tom lane



pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: Skipping schema changes in publication
Next
From: Tom Lane
Date:
Subject: Re: Making Vars outer-join aware