Hi,
On 2022-08-18 13:00:28 -0400, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > Looks good, except that it perhaps could go a tad further: TCL_SHARED_BUILD
> > isn't used either afaics?
>
> I wondered about that, but we do need TCL_SHARED_BUILD in configure
> itself, and the PGAC_EVAL_TCLCONFIGSH macro is going to AC_SUBST it.
> We could remove the line in Makefile.global but I don't think that
> buys much, and it might be more confusing not less so.
From the meson-generates-Makefile.global angle I like fewer symbols that have
to be considered in Makefile.global.in :). But even leaving that aside, I
think it's clearer to not have things in Makefile.global if they're not used.
But it's obviously not important.
Greetings,
Andres Freund
