Re: bug in json_to_record with arrays - Mailing list pgsql-hackers

From Tom Lane
Subject Re: bug in json_to_record with arrays
Date
Msg-id 2672.1417042123@sss.pgh.pa.us
Whole thread Raw
In response to Re: bug in json_to_record with arrays  (Stephen Frost <sfrost@snowman.net>)
List pgsql-hackers
Stephen Frost <sfrost@snowman.net> writes:
> * Tom Lane (tgl@sss.pgh.pa.us) wrote:
>> As far as your request for a better error message is concerned, I'm a
>> bit inclined to lay the blame on array_in rather than the JSON code.
>> Wouldn't it be better if it said
>> 
>> ERROR:  invalid input syntax for array: "["potter","chef","programmer"]"
>> DETAIL: Dimension value is missing.

> Sounds pretty reasonable to me, but I would just caution that we should
> check if that's considered 'leakproof' or not (or, if it is, if it'd
> ever possibly leak data it shouldn't or if it would only ever return
> information provided by the user).

array_in could only be regarded as leakproof if every element-type input
function it could ever call is also leakproof.  Which ain't the case,
so I sure hope it's not marked that way.  (Likewise record_in, range_in,
etc.)
        regards, tom lane



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: memory explosion on planning complex query
Next
From: Bruce Momjian
Date:
Subject: Re: Maximum number of WAL files in the pg_xlog directory