Re: pgsql-server: Add some strings for translation and remove some - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql-server: Add some strings for translation and remove some
Date
Msg-id 2670.1091637481@sss.pgh.pa.us
Whole thread Raw
In response to pgsql-server: Add some strings for translation and remove some  (dennis@svr1.postgresql.org (Dennis Bjorklund))
Responses Re: pgsql-server: Add some strings for translation and  (Dennis Bjorklund <db@zigo.dhs.org>)
List pgsql-committers
dennis@svr1.postgresql.org (Dennis Bjorklund) writes:
> Add some strings for translation and remove some cut'n'paste
> that makes it impossible to translate to other languages.

The way you've done this, the string will be passed through gettext
twice at runtime (once in this routine, once inside errmsg()).  That's
at best a waste of cycles and at worst a wrong answer.  (Though
a match on the translated string isn't likely, it's not impossible.)

You should use gettext_noop() not gettext() to mark these strings as
translatable.

            regards, tom lane

pgsql-committers by date:

Previous
From: tgl@svr1.postgresql.org (Tom Lane)
Date:
Subject: pgsql-server: Make use of backup label/history files to control recovery
Next
From: dennis@svr1.postgresql.org (Dennis Bjorklund)
Date:
Subject: pgsql-server: Translation updates