Re: Incorrect format in error message - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Incorrect format in error message
Date
Msg-id 26659.1459485031@sss.pgh.pa.us
Whole thread Raw
In response to Incorrect format in error message  (David Rowley <david.rowley@2ndquadrant.com>)
Responses Re: Incorrect format in error message  (David Rowley <david.rowley@2ndquadrant.com>)
Re: Incorrect format in error message  (David Rowley <david.rowley@2ndquadrant.com>)
List pgsql-hackers
David Rowley <david.rowley@2ndquadrant.com> writes:
> The attached fixes an error message which is incorrectly using an
> unsigned format specifier instead of a signed one.

I think that's the tip of the iceberg :-(.  For starters, the code
allows ObjectIdAttributeNumber without regard for the fact that the
next line will dump core on a negative attno.  Really though, what
astonishes me about this example is that we allow indexes at all on
system columns other than OID.  None of the other ones can possibly
have either a use-case or sensible semantics, can they?  We certainly
would not stop to update indexes after changing xmax, for example.
        regards, tom lane



pgsql-hackers by date:

Previous
From: David Rowley
Date:
Subject: Re: Parallel Queries and PostGIS
Next
From: Amit Kapila
Date:
Subject: Re: Updated backup APIs for non-exclusive backups