Re: A few warnings on Windows - Mailing list pgsql-hackers

From Tom Lane
Subject Re: A few warnings on Windows
Date
Msg-id 26334.1525291313@sss.pgh.pa.us
Whole thread Raw
In response to Re: A few warnings on Windows  (Thomas Munro <thomas.munro@enterprisedb.com>)
Responses Re: A few warnings on Windows  (Thomas Munro <thomas.munro@enterprisedb.com>)
List pgsql-hackers
Thomas Munro <thomas.munro@enterprisedb.com> writes:
> The only remaining warnings on those machines now come from the fact
> that our port_win32.h and Perl's XSUB.h both want to define macros to
> define macros for libc functions like mkdir etc.  plperl.h already
> seems to deal with other similar kinds of ugliness.  Perhaps if
> PG_NEED_PERL_XSUB_H is defined we should undefine port_win32.h's
> libc-stealing macros before including it?  Either way XSUB.h's
> definitions win.  That should get us to 0 warnings.  See attached (not
> tested).

Seems reasonable to me.  Pushed, we'll see what the buildfarm thinks.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Unportable code in autoprewarm.c
Next
From: Peter Eisentraut
Date:
Subject: Re: Is there a memory leak in commit 8561e48?