Re: [RFC] building postgres with meson -v8 - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: [RFC] building postgres with meson -v8
Date
Msg-id 261aa7b4-e70b-7a1a-a1e1-03c063911acc@enterprisedb.com
Whole thread Raw
In response to Re: [RFC] building postgres with meson -v8  (Andres Freund <andres@anarazel.de>)
Responses Re: [RFC] building postgres with meson -v8
Re: [RFC] building postgres with meson -v8
List pgsql-hackers
On 18.05.22 21:48, Andres Freund wrote:
> - CONFIGURE_ARGS - empty in meson, not clear what to fill it with

Ok to leave empty for now.

> - GETTIMEOFDAY_1ARG - test doesn't exist - I suspect it might not be necessary

Might be obsolete, consider removing.

> - PACKAGE_STRING, PACKAGE_TARNAME - unclear if they should be implemented?

leave out for now

> - AC_APPLE_UNIVERSAL_BUILD logic - which I don't think we need?

no

> - "missing" a bunch of defines that don't appear to be referenced:

Yeah, looks like these are implicitly defined by some autoconf check but 
then the result is only used within configure.ac itself, so isn't needed 
afterwards.

> - meson additional defines, seems harmless:
>    HAVE_GETTIMEOFDAY - only defined on windows rn
>    HAVE_SHM_UNLINK
>    HAVE_SSL_NEW
>    HAVE_STRTOQ
>    HAVE_STRTOUQ
>    HAVE_CRYPTO_NEW_EX_DATA

Yeah, that's the opposite of the previous.

I don't see any other issues in pg_config.h either.  Obviously, some 
niche platforms might uncover some issues, but it looks good for now.



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: allow building trusted languages without the untrusted versions
Next
From: Robert Haas
Date:
Subject: Re: allow building trusted languages without the untrusted versions