Re: BUG #6510: A simple prompt is displayed using wrong charset - Mailing list pgsql-bugs

From Tom Lane
Subject Re: BUG #6510: A simple prompt is displayed using wrong charset
Date
Msg-id 26179.1350231042@sss.pgh.pa.us
Whole thread Raw
In response to Re: BUG #6510: A simple prompt is displayed using wrong charset  (Alexander Law <exclusion@gmail.com>)
Responses Re: BUG #6510: A simple prompt is displayed using wrong charset
List pgsql-bugs
Alexander Law <exclusion@gmail.com> writes:

> +#ifdef WIN32
> +    termin = fopen("CONIN$", "r");
> +    termout = fopen("CONOUT$", "w+");
> +#else
>      termin = fopen(DEVTTY, "r");
>      termout = fopen(DEVTTY, "w");
> +#endif
>      if (!termin || !termout

My immediate reaction to this patch is "that's a horrible kluge, why
shouldn't we change the definition of DEVTTY instead?"  Is there a
similar issue in other places where we use DEVTTY?

Also, why did you change the termout output mode, is that important
or just randomness?

            regards, tom lane

pgsql-bugs by date:

Previous
From: Hiroshi Saito
Date:
Subject: Re: Sorry to bother you. Please tell me exactly how the compiler was built ODBC
Next
From: Josh Kupershmidt
Date:
Subject: Re: pg_ctl restart issue with relative paths