Another pgindent gripe - Mailing list pgsql-hackers

From Tom Lane
Subject Another pgindent gripe
Date
Msg-id 25441.1392333257@sss.pgh.pa.us
Whole thread Raw
Responses Re: Another pgindent gripe  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
I noticed that current pgindent wants to do this to a recently-added
comment in psql/copy.c:

*************** handleCopyIn(PGconn *conn, FILE *copystr
*** 627,633 ****                                       /*                                        * This code
erroneouslyassumes '\.' on a line alone                                        * inside a quoted CSV string terminates
the\copy.
 
!                                        *
http://www.postgresql.org/message-id/E1TdNVQ-0001ju-GO@wrigleys.postgresql.org                                       */
                                     if (strcmp(buf, "\\.\n") == 0 ||
strcmp(buf,"\\.\r\n") == 0)
 
--- 627,634 ----                                       /*                                        * This code
erroneouslyassumes '\.' on a line alone                                        * inside a quoted CSV string terminates
the\copy.
 
!                                        * http://www.postgresql.org/message-id/E1TdNVQ-0001ju-GO@w
!                                        * rigleys.postgresql.org                                        */
                         if (strcmp(buf, "\\.\n") == 0 ||                                               strcmp(buf,
"\\.\r\n")== 0)
 

Doesn't seem particularly friendly.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: issue with gininsert under very high load
Next
From: Bruce Momjian
Date:
Subject: Re: Another pgindent gripe