Re: [HACKERS] Unworkable column delimiter characters for COPY - Mailing list pgsql-patches

From Tom Lane
Subject Re: [HACKERS] Unworkable column delimiter characters for COPY
Date
Msg-id 25251.1198815933@sss.pgh.pa.us
Whole thread Raw
In response to Re: [HACKERS] Unworkable column delimiter characters for COPY  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: [HACKERS] Unworkable column delimiter characters for COPY  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-patches
Andrew Dunstan <andrew@dunslane.net> writes:
> Tom Lane wrote:
>> It seems we ought to forbid delimiter from matching CSV
>> quote or escape characters.  I'll let you clean up that case though...

> This should do the trick - I'll apply it tomorrow.

A couple thoughts:

* This test needs to appear further down --- it is not sensible until
after you've checked strlen() == 1 for all the strings involved.

* I see that we disallow the CSV quote character from appearing in the
null_print string, but not the escape character.  Is this
correct/sensible?  If it is correct, maybe the delimiter could also
match the escape character?

            regards, tom lane

pgsql-patches by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: [HACKERS] Unworkable column delimiter characters for COPY
Next
From: Michael Meskes
Date:
Subject: Re: Fix ecpg SQL CONNECT with variable user name